It is currently Oct 19th, '19, 02:40

Topic: Launcher.sh

Play Guild Wars 2™ on Linux easily
Visit the home page

Launcher.sh

Unread postby jukk » Feb 20th, '14, 20:54

Hi!
I have some feedback on the Launcher.sh script. I had some errors launching it in Fedora, so I took a look at it.

Row 141: I don't think this is correct bash syntax, you can't have 1..10 in a variable in { }. Better with a c syntax like
for (( i=$START;i<=$END;i++ )); do

Row 200, 201: Use quotes, otherwise if there is a space in the path, it will fail.

Row 203,204 s/Coudn't/Couldn't/g while we are at it.

pidof command is not present on my system. Replace with bash script function and/or check from the system for the existance of pidof or pgrep command (or some similar command) and use accordingly.

Regards,
jukk
User avatar
jukk
 
Guest
Guest
 

Re: Launcher.sh

Unread postby Anna » Mar 2nd, '14, 11:44

Hi, sorry for the late reply. We no longer use this script in the development version, but unfortunately the Wine Multimedia tree has currently become too different to merge with the CSMT patches again, so we've not been able to make any releases with our new tools.
3 Biggest Software Lies:
- The program's fully tested and bug-free.
- We're working on the documentation.
- Of course we can modify it.
Boxedfox.org
User avatar
Anna
Faux paws
 
Creator
Creator
 
USA
Posts: 13
Joined:
Dec 2nd, '13, 02:41
Location:
USA
Gender:
[♀] Transfeminine
Forum role:
Tech Guru
Operating system:
Linux

Re: Launcher.sh

Unread postby Konomi » Mar 2nd, '14, 11:47

Hi, the launcher script has been completely rewritten as of late but is not released yet. The for loop expression you're referring to is valid and was added in bash 3.0+ please see: http://www.cyberciti.biz/faq/bash-for-loop/. I'll fix up the other two issues you found add warnings for pgrep missing and maybe use ps and grep to replace pidof. Thanks for the reports!

We've been wanting to release a new build sometime and I do currently have a build that combines the DirectX stream code with the wine-multimedia code and wine 1.7.10 but it introduced other bugs. We may still do a release at some point though as one of the more important bugs that is gone is the armor change graphics corruption which was a big deal for me.
1. Follow the order of operations
2. Don't hurt anyone
3. Do what you want
4. Don't talk about fight club :3
Boxedfox.org
User avatar
Konomi
Bash script kitten
 
Creator
Creator
 
Australia
Posts: 29
Joined:
Dec 2nd, '13, 02:45
Location:
Australia
Gender:
[♀] Female
Forum role:
Tech Guru
Operating system:
Linux

Re: Launcher.sh

Unread postby Logan » May 3rd, '14, 02:24

Hi, the launcher script complains that it can't create a wineprefix.

Going to the launcher folder > wine > bin then running winecfg from there will create the wineprefix. After that the launcher runs fine.
.
Can the launcher do this automatically?
User avatar
Logan
 
Guest
Guest
 

Re: Launcher.sh

Unread postby Anna » May 3rd, '14, 21:43

Logan wrote:Hi, the launcher script complains that it can't create a wineprefix.

Going to the launcher folder > wine > bin then running winecfg from there will create the wineprefix. After that the launcher runs fine.
.
Can the launcher do this automatically?

Konomi will get back to you on this sometime tomorrow.
3 Biggest Software Lies:
- The program's fully tested and bug-free.
- We're working on the documentation.
- Of course we can modify it.
Boxedfox.org
User avatar
Anna
Faux paws
 
Creator
Creator
 
USA
Posts: 13
Joined:
Dec 2nd, '13, 02:41
Location:
USA
Gender:
[♀] Transfeminine
Forum role:
Tech Guru
Operating system:
Linux

Re: Launcher.sh

Unread postby Konomi » May 4th, '14, 09:56

Logan wrote:Hi, the launcher script complains that it can't create a wineprefix.

Going to the launcher folder > wine > bin then running winecfg from there will create the wineprefix. After that the launcher runs fine.
.
Can the launcher do this automatically?


Hi, what verison of the launcher are you using? This sounds like a bug I might've already fixed if you're using an older version. The current version of the tools is v1.3-2014.03.31 and the launcher version (look inside the comments) should be 1.7. If you're on this version and still getting it please run the launcher like this:

Code: Select all
bash -x ./Launcher.sh >> "$HOME/Launcher.sh.log"


Then send me the log file in your home directory. Please PM it as a message to me though as it will contain your user name and other possibly machine specific information.
1. Follow the order of operations
2. Don't hurt anyone
3. Do what you want
4. Don't talk about fight club :3
Boxedfox.org
User avatar
Konomi
Bash script kitten
 
Creator
Creator
 
Australia
Posts: 29
Joined:
Dec 2nd, '13, 02:45
Location:
Australia
Gender:
[♀] Female
Forum role:
Tech Guru
Operating system:
Linux

Re: Launcher.sh

Unread postby Temp » Jun 26th, '14, 16:56

Hi,

Did you find a solution to this problem? I get the same error "Launcher.sh couldn't create a wine prefix" and it can't seem to be solved by running winecfg.
User avatar
Temp
 
XP: 4 / 159
XP: 4 / 159
 
Posts: 3
Joined:
Jul 1st, '14, 22:11
Forum role:
Guest

Re: Launcher.sh

Unread postby Konomi » Jun 28th, '14, 12:29

Temp wrote:Hi,

Did you find a solution to this problem? I get the same error "Launcher.sh couldn't create a wine prefix" and it can't seem to be solved by running winecfg.


Have you tried the most recent release?
1. Follow the order of operations
2. Don't hurt anyone
3. Do what you want
4. Don't talk about fight club :3
Boxedfox.org
User avatar
Konomi
Bash script kitten
 
Creator
Creator
 
Australia
Posts: 29
Joined:
Dec 2nd, '13, 02:45
Location:
Australia
Gender:
[♀] Female
Forum role:
Tech Guru
Operating system:
Linux

Re: Launcher.sh

Unread postby Temp » Jun 30th, '14, 23:28

Yes, I still get the same error even with the latest release.
User avatar
Temp
 
XP: 4 / 159
XP: 4 / 159
 
Posts: 3
Joined:
Jul 1st, '14, 22:11
Forum role:
Guest

Re: Launcher.sh

Unread postby Konomi » Jul 1st, '14, 04:50

Temp wrote:Yes, I still get the same error even with the latest release.


Damn I thought I fixed that, I'll look into it more sorry.

EDIT: Okay things are getting complicated, I just did a clean install of the projects latest version and encountered no error. I'm going to need debug logs.

If anyone has this error do the following:

1. Open up your terminal and navigate to the directory you have Launcher.sh in
2. Run the following:

Code: Select all
bash -x ./Launcher.sh &> Launcher.debug
ls -R . &> Structure.debug


3. Send me the resulting files Launcher.debug and Structure.debug, you can use the forum IM or pop into IRC and PM me some links. Your logs will be only seen by me or team members and will be discarded after the bug is fixed for anyone concerned about privacy.
1. Follow the order of operations
2. Don't hurt anyone
3. Do what you want
4. Don't talk about fight club :3
Boxedfox.org
User avatar
Konomi
Bash script kitten
 
Creator
Creator
 
Australia
Posts: 29
Joined:
Dec 2nd, '13, 02:45
Location:
Australia
Gender:
[♀] Female
Forum role:
Tech Guru
Operating system:
Linux
Next

Return to WineGW2

 

Who is online

Users browsing this forum: No registered users and 2 guests

cron